Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve: Update container errors #160

Closed
2 tasks done
tokejepsen opened this issue Mar 8, 2024 · 4 comments
Closed
2 tasks done

Resolve: Update container errors #160

tokejepsen opened this issue Mar 8, 2024 · 4 comments
Labels
type: bug Something isn't working

Comments

@tokejepsen
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior:

Updating a container in the manager errors with:

Traceback (most recent call last):
  File "C:\Users\tokejepsen\ayon-core\client\ayon_core\tools\sceneinventory\view.py", line 236, in <lambda>
    lambda: self._update_containers(items, version=-1)
  File "C:\Users\tokejepsen\ayon-core\client\ayon_core\tools\sceneinventory\view.py", line 819, in _update_containers
    update_container(item, item_version)
  File "C:\Users\tokejepsen\ayon-core\client\ayon_core\pipeline\load\utils.py", line 517, in update_container
    return Loader().update(container, context)
  File "C:\Users\tokejepsen\ayon-core\client\ayon_core\hosts\resolve\plugins\load\load_clip.py", line 82, in update
    self.set_item_color(timeline_item, version=context["version"])
  File "C:\Users\tokejepsen\ayon-core\client\ayon_core\hosts\resolve\plugins\load\load_clip.py", line 130, in set_item_color
    version["parent"],
KeyError: 'parent'

Expected Behavior:

No response

Version

1.0.0

What platform you are running on?

Windows

Steps To Reproduce:

  1. Load a clip (EXR) into a timeline in Resolve.
  2. Switch version in the Manager.

Are there any labels you wish to add?

  • I have added the relevant labels to the bug report.

Relevant log output:

No response

Additional context:

No response

@BigRoy
Copy link
Collaborator

BigRoy commented Mar 8, 2024

Shouldn't parent key always be present on version data?

Unless the entity was queried with fields argument so that it excludes parent, but I believe the context being used here should contain that since those are the queries of the representation contexts?


Edit: it only happens on update?

If so, then it's likely due to this PR #130

@BigRoy
Copy link
Collaborator

BigRoy commented Mar 8, 2024

The issue is here

Those queries filter fields but we want to pass the full context to the Loader.update calls.

Bug was introduced with #130 indeed.

@jakubjezek001
Copy link
Member

hey @tokejepsen I believe this had been fixed already. Can you try again please?

@tokejepsen
Copy link
Member Author

hey @tokejepsen I believe this had been fixed already. Can you try again please?

Nice, resolved!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants