Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workfiles: Saving artist note workfile_info id error #414

Closed
2 tasks done
BigRoy opened this issue Apr 12, 2024 · 1 comment
Closed
2 tasks done

Workfiles: Saving artist note workfile_info id error #414

BigRoy opened this issue Apr 12, 2024 · 1 comment
Labels
type: bug Something isn't working

Comments

@BigRoy
Copy link
Collaborator

BigRoy commented Apr 12, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior:

In workfiles tool when saving an artist note I sometimes get this error:

# Traceback (most recent call last):
#   File "E:\dev\ayon-core\client\ayon_core\tools\workfiles\widgets\side_panel.py", line 107, in _on_save_click
#     self._controller.save_workfile_info(
#   File "E:\dev\ayon-core\client\ayon_core\tools\workfiles\control.py", line 448, in save_workfile_info
#     self._workfiles_model.save_workfile_info(
#   File "E:\dev\ayon-core\client\ayon_core\tools\workfiles\models\workfiles.py", line 702, in save_workfile_info
#     self._entities_model.save_workfile_info(
#   File "E:\dev\ayon-core\client\ayon_core\tools\workfiles\models\workfiles.py", line 547, in save_workfile_info
#     workfile_info["id"],
# KeyError: 'id'

It does seem to save the note - but it does error.

Expected Behavior:

No errors.

Version

1.0.0

What platform you are running on?

Windows

Steps To Reproduce:

  1. Open Workfile tool
  2. Press "Save As" to create a new save.
  3. For the new workfile, save an artist note.

(Tested in Maya 2024)

Are there any labels you wish to add?

  • I have added the relevant labels to the bug report.

Relevant log output:

# Traceback (most recent call last):
#   File "E:\dev\ayon-core\client\ayon_core\tools\workfiles\widgets\side_panel.py", line 107, in _on_save_click
#     self._controller.save_workfile_info(
#   File "E:\dev\ayon-core\client\ayon_core\tools\workfiles\control.py", line 448, in save_workfile_info
#     self._workfiles_model.save_workfile_info(
#   File "E:\dev\ayon-core\client\ayon_core\tools\workfiles\models\workfiles.py", line 702, in save_workfile_info
#     self._entities_model.save_workfile_info(
#   File "E:\dev\ayon-core\client\ayon_core\tools\workfiles\models\workfiles.py", line 547, in save_workfile_info
#     workfile_info["id"],
# KeyError: 'id'

Additional context:

No response

@BigRoy BigRoy added the type: bug Something isn't working label Apr 12, 2024
@BigRoy
Copy link
Collaborator Author

BigRoy commented Jun 18, 2024

This was fixed with #647

This issue was also reported on discord here

@BigRoy BigRoy closed this as completed Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant