Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract Review: Give artist control on hardware fog for Extract Review #15

Open
2 tasks done
BigRoy opened this issue Jul 8, 2024 · 3 comments
Open
2 tasks done
Labels
type: enhancement Improvement of existing functionality or minor addition

Comments

@BigRoy
Copy link
Contributor

BigRoy commented Jul 8, 2024

Is there an existing issue for this?

  • I have searched the existing issues.

Please describe the feature you have in mind and explain what the current shortcomings are?

Currently the Hardware Fog settings (and more!) for Extract Review are all defined by Studio/Project Settings: ayon+settings://maya/publish/ExtractPlayblast/profiles/0/capture_preset/ViewportOptions/fogging
image

However, more often than not the "start" and "end" for hardware fog may be very scene dependent and usually not something you'd want to override project-wide. We should make it so that the artist can take control over whatever is scene-specific, but maybe force other defaults project wide from e.g. presets.

How would you imagine the implementation of the feature?

The problematic thing here becomes "how" do we allow the user to set the scene-specific settings. We still want the artist to be able to configure things the way they usually do - because that's what they know.

Luckily the hardware fog is already defined scene-wide instead of per viewport or camera - so we could allow a toggle to "use scene settings" easily (which is on hardwareRenderingGlobals node).

image

Another approach could be to still store it on the instance, but have some sort of Publisher UI button to take the settings from the scene easily so that at least the user can publish what they're seeing, etc.

Are there any labels you wish to add?

  • I have added the relevant labels to the enhancement request.

Describe alternatives you've considered:

No response

Additional context:

No response

@BigRoy
Copy link
Contributor Author

BigRoy commented Jul 8, 2024

@antirotor Any good ideas on how this could be nicely exposed and presented to the artist?

@antirotor
Copy link
Member

What about adding checkbox to settings next to the each viewport option that when enabled will be exposed as instance attribute of Extract Playblast?

@antirotor antirotor added the type: enhancement Improvement of existing functionality or minor addition label Oct 7, 2024
@BigRoy
Copy link
Contributor Author

BigRoy commented Oct 7, 2024

What about adding checkbox to settings next to the each viewport option that when enabled will be exposed as instance attribute of Extract Playblast?

So basically something similar to what we did with the Alembic export options?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

No branches or pull requests

2 participants