Improve

Author: yoanm

.github/actions/reports-group/.nvmrc

@@ -0,0 +1 @@
+20

.github/actions/reports-group/attach-check-run-to-triggering-workflow-action/dist/index.js

@@ -1,6 +1,6 @@
 const core = require("@actions/core"); // @TODO move to 'imports from' when moved to TS !
 
-if (!!core.getState('check-run-id')) {
+if (!!core.getState('has-been-triggered')) {
     require('./src/cleanup');
 } else {
     require('./src/main');

.github/actions/reports-group/attach-check-run-to-triggering-workflow-action/dist/index.js.map

@@ -6,6 +6,7 @@ const ghaHelpers = require('../node-gha-helpers');
 const formatMarkdownUrl = (title, link) => '<a href="' + link + '" target="blank">' + title + '</a>';
 
 async function run() {
+    core.saveState('has-been-triggered', 1);
     /** INPUTS **/
     const githubToken = core.getInput('github-token', {required: true});
     const jobStatus = core.getInput('job-status', {required: true});
@@ -71,6 +72,6 @@ async function run() {
 }
 
 run().catch(e => {
-    core.info('Error caught and ignored ' + e.message);
+    core.warning('Error caught and ignored ' + e.message);
     core.debug('Error=' + JSON.stringify(e));
 });

.github/actions/reports-group/attach-check-run-to-triggering-workflow-action/index.js

@@ -5,9 +5,6 @@ const core = require('@actions/core'); // @TODO move to 'imports from' when move
 
 const SDK = require('./node-sdk'); // @TODO move to 'imports from' when moved to TS !
 
-// @TODO replace json by glob-string as output ?? Same as string format but with glob compatible path list
-
-// (easier to manage for inner code, while end-user is still able to fall back on string format with a simple split)
 async function run() {
     const trustedPathConverter = SDK.path.trustedPathHelpers();
     /** INPUTS **/
@@ -36,18 +33,25 @@ async function run() {
     core.debug('Filter metadata list');
     trustedMetadataList = SDK.filter.filterMetadataList(
         trustedMetadataList,
-        core.getMultilineInput('exclude-groups'), core.getMultilineInput('exclude-formats'), core.getMultilineInput('exclude-flags'), core.getMultilineInput('exclude-paths'),
-        core.getMultilineInput('only-include-groups'), core.getMultilineInput('only-include-formats'), core.getMultilineInput('only-include-flags'), core.getMultilineInput('only-include-paths')
-    );
+        {
+            groups: core.getMultilineInput('exclude-groups'),
+            formats: core.getMultilineInput('exclude-formats'),
+            flags: core.getMultilineInput('exclude-flags'),
+            paths: core.getMultilineInput('exclude-paths'),
+        },
+        {
+            groups: core.getMultilineInput('only-include-groups'),
+            formats: core.getMultilineInput('only-include-formats'),
+            flags: core.getMultilineInput('only-include-flags'),
+            paths: core.getMultilineInput('only-include-paths')
+        }
+    )
     core.debug('New metadata list=' + JSON.stringify(trustedMetadataList));
     // Apply `artifacts` mode if needed
     if (ENABLE_ARTIFACT_MODE) {
         core.debug('Apply artifact mode');
-        if (trustedPathInput.split('\n').length !== 1 || trustedPathInput.includes('*') || trustedPathInput.includes('?') || trustedPathInput.includes(']')) {
-            core.setFailed('You must provide a single valid path when `artifacts-mode` option is enabled !')
-        }
         if (!statSync(trustedPathInput).isDirectory()) {
-            core.setFailed('You must provide a single valid path when `artifacts-mode` option is enabled !')
+            core.setFailed('Provided path is not a valid directory. You must provide a single valid path when `artifacts-mode` is enabled !')
         }
         const artifactDownloadDirectory = SDK.path.withTrailingSeparator(path.resolve(trustedPathInput));
         const artifactList = new Set();
@@ -59,8 +63,7 @@ async function run() {
 
             metadata.artifact = artifactName;
             artifactList.add(metadata.artifact);
-            metadata.path = pathFromDwlDirectory;
-            metadata.path = SDK.path.withTrailingSeparator(0 === metadata.path.length ? '.' : metadata.path);
+            metadata.path = SDK.path.withTrailingSeparator(0 === pathFromDwlDirectory.length ? '.' : pathFromDwlDirectory);
             metadata.reports = metadata.reports.map(v => path.relative(v, artifactDownloadDirectory));
 
             return metadata;
@@ -85,8 +88,7 @@ async function run() {
     let trustedMetadataListOfList = [trustedMetadataList];
     /** @type {MergeField[]} */
     const groupByItemList = GROUP_BY_INPUT.length > 0 ? GROUP_BY_INPUT.split(',') : [];
-    const isMultiGroup = groupByItemList.length > 0;
-    if (isMultiGroup) {
+    if (groupByItemList.length > 0) {
         core.info('Merge metadata list');
         trustedMetadataListOfList = SDK.merge.groupMetadataList(trustedMetadataList, groupByItemList);
         core.debug('New metadata list=' + JSON.stringify(trustedMetadataListOfList));