Skip to content

Commit a5ddaea

Browse files
committed
Add TODO for later
1 parent 115e9a2 commit a5ddaea

File tree

4 files changed

+14
-1
lines changed

4 files changed

+14
-1
lines changed

.github/actions/reports-group/codacy-uploader/action.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,8 @@ runs:
5353
glue-string: ',' # Ensure glue string as it's the expected one by the uploader
5454
follow-symbolic-links: ${{ inputs.follow-symbolic-links }}
5555

56+
# @TODO Use bash instead and rely on JQ ?
57+
# Or create an *internal* action (not published on marketplace and stored inside this action repo) taking metadata JSON as input and returning each property the uploader has ?
5658
- name: Build uploader option
5759
id: build-uploader-options
5860
uses: actions/github-script@v7

.github/actions/reports-group/codecov-uploader/action.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,8 @@ runs:
5959
glue-string: ',' # Ensure glue string as it's the expected one by the uploader
6060
follow-symbolic-links: ${{ inputs.follow-symbolic-links }}
6161

62+
# @TODO Use bash instead and rely on JQ ?
63+
# Or create an *internal* action (not published on marketplace and stored inside this action repo) taking metadata JSON as input and returning each property the uploader has ?
6264
- name: Build uploader option
6365
id: build-uploader-options
6466
uses: actions/github-script@v7

.github/workflows/codacy-upload-from-artifacts.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
# To store on same repo as reports-group/codacy-uploader action if doable !
12
name: 'Codacy report groups upload'
23
on:
34
workflow_call:
@@ -23,6 +24,11 @@ on:
2324
description: TODO
2425
value: ${{ jobs.upload.outputs.reports }}
2526

27+
# @TODO Investigate: `workflow_run` don't create a status check on the related PR !
28+
# Would it be handy/secure/not to complex to create a reports-group/check-run-from-workflow-run which:
29+
# - Would need to be added as first workflow wtep in order to create a `in-progress` check-run with all info fetched from the triggering workflow
30+
# - Add a `fail-if-caller-failed` option which would create `failed` check-run and exit with an error ?
31+
# - Would update the check-run during post-process with the current status of the triggered workflow
2632
jobs:
2733
upload:
2834
name: Upload all reports

.github/workflows/codecov-upload-from-artifacts.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
# To store on same repo as reports-group/codecov-uploader action if doable
12
name: 'Codecov report groups upload'
23
on:
34
workflow_call:
@@ -8,7 +9,7 @@ on:
89
run-id:
910
description: |
1011
The id of the workflow run where the artifacts were uploaded from (default to current run).
11-
In case artefacts have been uploadded from another run, original workflow run has to be provided as well as `ARTEFACT_DOWNLOAD_TOKEN` secret !
12+
In case artefacts have been uploadded from another run, this input must be filled with original workflow !
1213
required: false
1314
default: "${{ github.run_id }}"
1415
type: string
@@ -56,6 +57,8 @@ jobs:
5657
- name: DEBUG
5758
run: echo '${{ toJson(steps.find-groups.outputs) }}'
5859

60+
# @TODO create a reports-group/find-from-artifacts action returning a map of group name to the related artefacts
61+
# (alternatively, update reports-group/find to manage it, like with a `from-artifacts` ??)
5962
- name: Build matrix
6063
id: build-matrix
6164
uses: actions/github-script@v7

0 commit comments

Comments
 (0)