Skip to content

Commit 7c8701d

Browse files
committed
[BC] Add sf 7.0 and drop 4.4
1 parent 1450937 commit 7c8701d

File tree

3 files changed

+24
-23
lines changed

3 files changed

+24
-23
lines changed

.github/workflows/reusable-CI-workflow.yml

Lines changed: 16 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -63,26 +63,28 @@ jobs:
6363
symfony-version: '${{ needs.fetch-supported-versions.outputs.symfony-max }}'
6464
# Fix - behat/gherkin => Avoid issue with behat <-> gherkin packages (See https://github.com/Behat/Gherkin/issues/317)
6565
pkg-extra-constraints: --with 'behat/gherkin:~4.12.0'
66-
- job-name: Up to date versions - Sf 5.4 case
66+
- job-name: Up to date versions - Sf 6.4 case
6767
php-version: '${{ needs.fetch-supported-versions.outputs.php-max }}'
68-
symfony-version: '5.4'
68+
symfony-version: '6.4'
6969
# Fix - behat/gherkin => Avoid issue with behat <-> gherkin packages (See https://github.com/Behat/Gherkin/issues/317)
7070
pkg-extra-constraints: --with 'behat/gherkin:~4.12.0'
7171
- job-name: Bare minimum # => Lowest versions allowed by composer config
7272
php-version: '${{ needs.fetch-supported-versions.outputs.php-min }}'
7373
symfony-version: '${{ needs.fetch-supported-versions.outputs.symfony-min }}'
74-
- job-name: Bare minimum - Sf 5.4 case
75-
php-version: '${{ needs.fetch-supported-versions.outputs.php-min }}'
76-
symfony-version: '5.4'
77-
- job-name: Late PHP migration # => Highest symfony version with lowest php version allowed by composer config
74+
- job-name: Bare minimum - Sf 6.4 case
7875
# Fix - Sf 6.4 require php 8.1 minimum !
79-
php-version: ${{ ( needs.fetch-supported-versions.outputs.symfony-max == '6.4' && needs.fetch-supported-versions.outputs.php-min == '8.0' ) && '8.1' || needs.fetch-supported-versions.outputs.php-min }}
76+
php-version: ${{ ( needs.fetch-supported-versions.outputs.php-min == '8.0' ) && '8.1' || needs.fetch-supported-versions.outputs.php-min }}
77+
symfony-version: '6.4'
78+
- job-name: Late PHP migration # => Highest symfony version with lowest php version allowed by composer config
79+
# Fix - Sf 7.0 require php 8.1 minimum, most of deps require 8.2 !
80+
php-version: ${{ ( needs.fetch-supported-versions.outputs.symfony-max == '7.0' && needs.fetch-supported-versions.outputs.php-min == '8.0' ) && '8.2' || needs.fetch-supported-versions.outputs.php-min }}
8081
symfony-version: '${{ needs.fetch-supported-versions.outputs.symfony-max }}'
8182
- job-name: Late Symfony migration # => Lowest symfony version with highest php version allowed by composer config
8283
php-version: '${{ needs.fetch-supported-versions.outputs.php-max }}'
8384
symfony-version: '${{ needs.fetch-supported-versions.outputs.symfony-min }}'
8485
# Fix - behat/gherkin => Avoid issue with behat <-> gherkin packages (See https://github.com/Behat/Gherkin/issues/317)
85-
pkg-extra-constraints: --with 'behat/gherkin:~4.12.0'
86+
# Fix - symfony/yaml => Avoid issue between symfony/yaml and symfony/framework-bundle (not compatible with some versions due to incomplete function signatures)
87+
pkg-extra-constraints: --with 'behat/gherkin:~4.12.0' ${{ ( needs.fetch-supported-versions.outputs.symfony-min == '5.4' && needs.fetch-supported-versions.outputs.php-max == '8.4' ) && '--with "symfony/yaml:~6.4.0"' || '' }}
8688
steps:
8789
- name: Check out code
8890
uses: actions/checkout@v5
@@ -248,20 +250,19 @@ jobs:
248250
php-version: ${{ needs.fetch-supported-versions.outputs.php-next }}
249251
symfony-version: ${{ needs.fetch-supported-versions.outputs.symfony-min }}
250252
# Fix - behat/gherkin => Avoid issue with behat <-> gherkin packages (See https://github.com/Behat/Gherkin/issues/317)
251-
pkg-extra-constraints: behat/gherkin:~4.12.0
253+
# Fix - symfony/yaml => Avoid issue between symfony/yaml and symfony/framework-bundle (not compatible with some versions due to incomplete function signatures)
254+
pkg-extra-constraints: behat/gherkin:~4.12.0 ${{ ( needs.fetch-supported-versions.outputs.symfony-min == '5.4' && needs.fetch-supported-versions.outputs.php-next == '8.5' ) && 'symfony/yaml:~6.4.0' || '' }}
252255
- job-name: Symfony with highest supported PHP version
253256
php-version: ${{ needs.fetch-supported-versions.outputs.php-max }}
254257
symfony-version: ${{ needs.fetch-supported-versions.outputs.symfony-next }}
255258
# Fix - behat/gherkin => Avoid issue with behat <-> gherkin packages (See https://github.com/Behat/Gherkin/issues/317)
256-
# Fix - symfony/framework-bundle - Framework bundle <7.0 require php 8.1 minimum !
257-
pkg-extra-constraints: behat/gherkin:~4.12.0 ${{ ( needs.fetch-supported-versions.outputs.symfony-next == '7.0' && needs.fetch-supported-versions.outputs.php-max == '8.4' ) && 'symfony/framework-bundle:~7.0.0@dev' || '' }}
259+
pkg-extra-constraints: behat/gherkin:~4.12.0
258260
- job-name: Symfony with lowest supported PHP version
259-
# Fix - Sf 7.0 require php 8.1 minimum, most of deps require 8.2 !
260-
php-version: ${{ ( needs.fetch-supported-versions.outputs.symfony-next == '7.0' && needs.fetch-supported-versions.outputs.php-min == '8.0' ) && '8.2' || needs.fetch-supported-versions.outputs.php-min }}
261+
# Fix - Sf 7.1 require php 8.2 minimum !
262+
php-version: ${{ ( needs.fetch-supported-versions.outputs.symfony-next == '7.1' && needs.fetch-supported-versions.outputs.php-min == '8.0' ) && '8.2' || needs.fetch-supported-versions.outputs.php-min }}
261263
symfony-version: ${{ needs.fetch-supported-versions.outputs.symfony-next }}
262264
# Fix - behat/gherkin => Avoid issue with behat <-> gherkin packages (See https://github.com/Behat/Gherkin/issues/317)
263-
# Fix - symfony/framework-bundle - Framework bundle <7.0 require php 8.1 minimum !
264-
pkg-extra-constraints: behat/gherkin:~4.12.0 ${{ ( needs.fetch-supported-versions.outputs.symfony-next == '7.0' && needs.fetch-supported-versions.outputs.php-min == '8.0' ) && 'symfony/framework-bundle:~7.0.0@dev' || '' }}
265+
pkg-extra-constraints: behat/gherkin:~4.12.0
265266

266267
steps:
267268
- name: Check out code
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
{
22
"php": {"min": "8.0", "max": "8.4", "next": "8.5"},
3-
"symfony": {"min": "4.4", "max": "6.4", "next": "7.0"}
3+
"symfony": {"min": "5.4", "max": "7.0", "next": "7.1"}
44
}

composer.json

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -34,11 +34,11 @@
3434
"require": {
3535
"php": "^8.0",
3636
"ext-json": "*",
37-
"symfony/config": "^4.4 || ^5.4 || ^6.0",
38-
"symfony/dependency-injection": "^4.4 || ^5.4 || ^6.0",
39-
"symfony/event-dispatcher-contracts": "^1.0 || ^2.0",
40-
"symfony/http-foundation": "^4.4 || ^5.4 || ^6.0",
41-
"symfony/http-kernel": "^4.4 || ^5.4 || ^6.0",
37+
"symfony/config": "^5.4 || ^6.0 || ^7.0",
38+
"symfony/dependency-injection": "^5.4 || ^6.0 || ^7.0",
39+
"symfony/event-dispatcher-contracts": "^2.0 || ^3.0",
40+
"symfony/http-foundation": "^5.4 || ^6.0 || ^7.0",
41+
"symfony/http-kernel": "^5.4 || ^6.0 || ^7.0",
4242
"yoanm/jsonrpc-server-doc-sdk": "^0.3 || ^1.0",
4343
"yoanm/jsonrpc-server-sdk": "^3.3",
4444
"yoanm/symfony-jsonrpc-http-server": "^3.3"
@@ -53,8 +53,8 @@
5353
"phpunit/php-code-coverage": "^9.2.4",
5454
"phpunit/phpunit": "^9.0",
5555
"squizlabs/php_codesniffer": "^3.5",
56-
"symfony/framework-bundle": "^4.4 || ^5.4 || ^6.0",
57-
"symfony/routing": "^4.4 || ^5.4 || ^6.0",
56+
"symfony/framework-bundle": "^5.4 || ^6.0 || ^7.0",
57+
"symfony/routing": "^5.4 || ^6.0 || ^7.0",
5858
"yoanm/php-unit-extended": "^2.0.2"
5959
},
6060
"config": {

0 commit comments

Comments
 (0)