Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: href link with HTML ID does not link to the expected URL #1155

Closed
1 task done
carboncrystal opened this issue Jan 2, 2024 · 3 comments · Fixed by #1306
Closed
1 task done

bug: href link with HTML ID does not link to the expected URL #1155

carboncrystal opened this issue Jan 2, 2024 · 3 comments · Fixed by #1306
Assignees
Labels

Comments

@carboncrystal
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

  1. Go to Scan Findings (Menu: Scan History > Select your project > View Results).

  2. Here are the menus:

  • Home
  • Subdomains
  • S3 Buckets
  • Interesting Recon
  • Screenshots
  • Directories
  • URLs
  • Vulnerabilities
  • OSINT
  • Visualization
  1. For example, if you hover over the Directories menu you will see that the ID is listed in the URL (#directories-tab), something like: https://127.0.0.1/scan/myprojectname/detail/15#directories-tab.

  2. Let's go deeper with the above example: After you access the Directories menu you can see something like: https://127.0.0.1/scan/myprojectname/detail/11#dir_Jan_01_2024_14_24_54

What is the problem?

href link with HTML ID does not link to the expected URL. Trying to open the above links in a new tab will not work, you will always be redirected to Home!

So you won't be able to send these HTML ID links to Jira (to your colleagues), or by email. So you can't map Attack Surface or Vulnerability Assessment in a clear way!

This bug is annoying as hell!

Expected Behavior

href link with HTML ID to link to the expected URL

Steps To Reproduce

Explained at Current Behavior field.

Environment

- reNgine: 2.0.2
- OS: Ubuntu 22.04.3 LTS
- Python: Python 3.10.12
- Docker Engine: latest
- Docker Compose: latest
- Browser: Firefox, Chrome

Anything else?

No response

@carboncrystal carboncrystal added the bug Something isn't working label Jan 2, 2024
Copy link
Contributor

github-actions bot commented Jan 2, 2024

👋 Hi @carboncrystal,
Issues is only for reporting a bug/feature request. Please read documentation before raising an issue https://rengine.wiki
For very limited support, questions, and discussions, please join reNgine Discord channel: https://discord.gg/azv6fzhNCE
Please include all the requested and relevant information when opening a bug report. Improper reports will be closed without any response.

@psyray
Copy link
Contributor

psyray commented Jan 12, 2024

Thanks for reporting
I will have a look

@yogeshojha
Copy link
Owner

Hey @carboncrystal

Thank you for reporting this.

A new feature has been added when clicked on the tabs inside scan results, will append the url hash on the browser. When the URL is accessed, the tab will be automatically clicked, which can be useful for navigation.

Also, navigation inside tabs is added, for example when clicked on Subdomains tab, and then Screenshot tab, you can use back button to go back to Subdomains tab, earlier it would go back to the previous page and not previous tab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants