Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Too many private API methods #22

Open
zanderwar opened this issue Oct 19, 2019 · 1 comment
Open

Too many private API methods #22

zanderwar opened this issue Oct 19, 2019 · 1 comment

Comments

@zanderwar
Copy link

zanderwar commented Oct 19, 2019 •
edited
Loading

Hi, I ran into an issue that was a bit of a pain for me

I have an AvatarService class which can be handed a "default avatar", I've extended it so that the default avatar accepts a LetterAvatar instance. The issue is, both the AvatarService and the LetterAvatar require a size to be specified. I can't adjust the size of a LetterAvatar instance once it's been constructed and I'm not a fan of modifying vendor packages.

See pull request #23
@ikhsan017
Copy link

I second this, as when used as a service, we can generate multiple avatar from single object

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ikhsan017 @zanderwar