Add tests to cover changes

Author: yann-eugone

src/batch-doctrine-dbal/src/DoctrineDBALInsertWriter.php

@@ -33,10 +33,6 @@ public function __construct(ConnectionRegistry $doctrine, string $table, string
      */
     public function write(iterable $items): void
     {
-        if (!\is_iterable($items)) {
-            throw UnexpectedValueException::type('iterable', $items);
-        }
-
         foreach ($items as $item) {
             if (!\is_array($item)) {
                 throw UnexpectedValueException::type('array', $item);

src/batch-doctrine-dbal/tests/DoctrineDBALInsertWriterTest.php

@@ -5,7 +5,9 @@
 namespace Yokai\Batch\Tests\Bridge\Doctrine\DBAL;
 
 use Doctrine\DBAL\Types\Types;
+use Generator;
 use Yokai\Batch\Bridge\Doctrine\DBAL\DoctrineDBALInsertWriter;
+use Yokai\Batch\Exception\UnexpectedValueException;
 
 class DoctrineDBALInsertWriterTest extends DoctrineDBALTestCase
 {
@@ -36,4 +38,11 @@ public function test(): void
             ['firstName' => 'Jack', 'lastName' => 'Doe'],
         ], $this->findAll('persons'));
     }
+
+    public function testItemNotAnArray(): void
+    {
+        $this->expectException(UnexpectedValueException::class);
+        $writer = new DoctrineDBALInsertWriter($this->doctrine, 'persons');
+        $writer->write(['string']);
+    }
 }

src/batch-symfony-console/tests/RunJobCommandTest.php

@@ -4,15 +4,16 @@
 
 namespace Yokai\Batch\Tests\Bridge\Symfony\Console;
 
+use JsonException;
 use PHPUnit\Framework\TestCase;
 use Prophecy\Argument;
 use Prophecy\PhpUnit\ProphecyTrait;
 use Prophecy\Prophecy\ObjectProphecy;
-use Symfony\Component\Console\Exception\InvalidArgumentException;
 use Symfony\Component\Console\Output\OutputInterface;
 use Symfony\Component\Console\Tester\CommandTester;
 use Yokai\Batch\BatchStatus;
 use Yokai\Batch\Bridge\Symfony\Console\RunJobCommand;
+use Yokai\Batch\Exception\UnexpectedValueException;
 use Yokai\Batch\Failure;
 use Yokai\Batch\JobExecution;
 use Yokai\Batch\Launcher\JobLauncherInterface;
@@ -50,12 +51,20 @@ private function execute(string $configuration = null, int $verbosity = OutputIn
 
     public function testRunWithMalformedConfiguration(): void
     {
-        $this->expectException(InvalidArgumentException::class);
+        $this->expectException(JsonException::class);
 
         $this->jobLauncher->launch(Argument::cetera())->shouldNotBeCalled();
         $this->execute('{]');
     }
 
+    public function testRunWithInvalidConfiguration(): void
+    {
+        $this->expectException(UnexpectedValueException::class);
+
+        $this->jobLauncher->launch(Argument::cetera())->shouldNotBeCalled();
+        $this->execute('"string"');
+    }
+
     /**
      * @dataProvider verbosity
      */

src/batch/tests/SummaryTest.php

@@ -5,6 +5,7 @@
 namespace Yokai\Batch\Tests;
 
 use PHPUnit\Framework\TestCase;
+use Yokai\Batch\Exception\UnexpectedValueException;
 use Yokai\Batch\Summary;
 
 class SummaryTest extends TestCase
@@ -97,4 +98,26 @@ public function testCount(): void
 
         self::assertCount(0, $summary);
     }
+
+    public function testAppend(): void
+    {
+        $summary = new Summary(['empty' => [], 'init' => [1, 2]]);
+        $summary->append('empty', 1);
+        $summary->append('empty', 2);
+        $summary->append('empty', 3);
+        $summary->append('init', 3);
+        $summary->append('undefined', 1);
+        $summary->append('undefined', 2);
+        $summary->append('undefined', 3);
+        self::assertSame([1, 2, 3], $summary->get('empty'));
+        self::assertSame([1, 2, 3], $summary->get('init'));
+        self::assertSame([1, 2, 3], $summary->get('undefined'));
+    }
+
+    public function testAppendNotAnArray(): void
+    {
+        $this->expectException(UnexpectedValueException::class);
+        $summary = new Summary(['init' => 'string']);
+        $summary->append('init', 3);
+    }
 }