Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR comment is not posted #26

Open
sh-jthorpe opened this issue Jul 31, 2024 · 1 comment
Open

PR comment is not posted #26

sh-jthorpe opened this issue Jul 31, 2024 · 1 comment

Comments

@sh-jthorpe
Copy link

sh-jthorpe commented Jul 31, 2024

The action runs successfully, has output in the github action run, but a comment isn't posted to the PR.

      - uses: yokawasa/action-sqlcheck@v1.5.0
        with: 
          post-comment: true
          risk-level: 2
          token: ${{ secrets.GITHUB_TOKEN }}
          directories: |
            Sql

I don't see any obvious issues with the post_pr_comment method.

Maybe write it to $GITHUB_OUTPUT, so that users can post a comment themselves?

@yokawasa
Copy link
Owner

yokawasa commented Nov 4, 2024

@sh-jthorpe I apologize for not responding for so long 🙏
Can you try with risk-level: 3 like this?

      - uses: yokawasa/action-sqlcheck@v1.5.0
        with: 
          post-comment: true
          risk-level: 3
          token: ${{ secrets.GITHUB_TOKEN }}
          directories: |
            Sql

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants