Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix package definition #1489

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix package definition #1489

wants to merge 3 commits into from

Conversation

0111b
Copy link

@0111b 0111b commented Jul 26, 2024

When XcodeGen used as a dependency in the project with same dependencies package definition became invalid.
This PR fixes this issue.

Screenshot 2024-07-26 at 15 19 08

Fixes #1490

Copy link
Owner

@yonaskolb yonaskolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0111b What's the swift version of the package you're importing XcodeGen into? We can probably update the swift version in the xcodegen package to something like 5.9 at this point

@0111b
Copy link
Author

0111b commented Aug 1, 2024

@yonaskolb I'm using exactly Swift 5.9. I didn't think about backward compatibility.
Should I create a separate Package@swift-5.9.swift ?

@yonaskolb
Copy link
Owner

At this point I'm fine with dropping older versions, so no need for Package@swift-5.9.swift Can you make that change here. I'll handle the release notes after merging

@0111b
Copy link
Author

0111b commented Aug 2, 2024

@yonaskolb I've bumped swift tools version in the package manifest

@0111b 0111b force-pushed the fix-package branch 2 times, most recently from bd31812 to 341da44 Compare August 2, 2024 09:38
@0111b
Copy link
Author

0111b commented Aug 2, 2024

It looks like CI failed due API rate limit issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error building XcodeGen as a dependency
2 participants