-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix package definition #1489
base: master
Are you sure you want to change the base?
Fix package definition #1489
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@0111b What's the swift version of the package you're importing XcodeGen into? We can probably update the swift version in the xcodegen package to something like 5.9 at this point
@yonaskolb I'm using exactly Swift 5.9. I didn't think about backward compatibility. |
At this point I'm fine with dropping older versions, so no need for |
@yonaskolb I've bumped swift tools version in the package manifest |
bd31812
to
341da44
Compare
It looks like CI failed due API rate limit issue |
When XcodeGen used as a dependency in the project with same dependencies package definition became invalid.
This PR fixes this issue.
Fixes #1490