Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with ggplot2 3.5.0 #27

Closed
teunbrand opened this issue Jan 22, 2024 · 2 comments
Closed

Compatibility with ggplot2 3.5.0 #27

teunbrand opened this issue Jan 22, 2024 · 2 comments

Comments

@teunbrand
Copy link

Hello there,

We have been preparing a new release of ggplot2 and during a reverse dependency check, and it seemed ggedit's checks failed. I tried to reproduce this locally, and it seems to occur both with the current CRAN version and the upcoming version of ggplot2.

The problem appears to originate in R/clone_facet.R, where it seems that some of the assumptions have become outdated. The new ggplot2 version adds two additional arguments to both facet_wrap() and facet_grid().

If you'd like to test yourself against ggplot2's release candidate, you can install it with the code below:

remotes::install_github("tidyverse/ggplot2", ref = remotes::github_pull("5592"))

The release of ggplot2 3.5.0 is scheduled for the 12th of February. The progress of the release can be tracked in tidyverse/ggplot2#5588. We hope to have informed you in a timely manner about upcoming changes.

@teunbrand
Copy link
Author

This is just a friendly reminder that the release is scheduled soon.

@yonicd
Copy link
Owner

yonicd commented Feb 12, 2024

package updated for 3.5.0 ggplot2 release d8bf8df

@yonicd yonicd closed this as completed Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants