Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error occurs when clicking back button in the document - "document not attached" #146

Open
devleejb opened this issue Feb 6, 2024 · 8 comments
Assignees
Labels
bug 🐞 Something isn't working

Comments

@devleejb
Copy link
Member

devleejb commented Feb 6, 2024

What happened:
When clicking the back button in the document, an error message stating "document not attached" is displayed.

What you expected to happen:
Clicking the back button should navigate to the previous page without any error message.

How to reproduce it (as minimally and precisely as possible):

  1. Open the document.
  2. Perform some actions within the document.
  3. Click the back button.

Anything else we need to know?:
The error message occurs consistently whenever the back button is clicked.

Environment:

  • Operating system: ALL
  • Browser and version: ALL
  • CodePair version: ALL
@devleejb devleejb added the bug 🐞 Something isn't working label Feb 6, 2024
@devleejb devleejb added this to the Bug milestone Feb 6, 2024
@devleejb devleejb added this to CodePair Feb 6, 2024
@devleejb devleejb moved this to Backlog in CodePair Jul 31, 2024
@devleejb devleejb modified the milestones: Bug, v0.1.0 Jul 31, 2024
@devleejb devleejb removed this from the v0.1.0 milestone Jul 31, 2024
@rappire
Copy link

rappire commented Aug 3, 2024

Title

Fix issue with continuous PushPullChanges requests after detaching document

Content

What this PR does / why we need it?

This PR addresses a bug where continuous PushPullChanges requests are sent even after detaching a document, causing errors in the process. The issue occurs when navigating back triggers the document detach process.

In the yorkie-js-sdk, when editing a document, PushPullChanges requests are sent at specified intervals. However, the problem arises when detaching a document in the sdk. Despite the detach operation, the loop responsible for sending PushPullChanges requests is not terminated. As a result, the yorkie server receives requests for a detached document, leading to errors.

에러
에러2

Once an error occurs, the loop is terminated, preventing further issues from arising.

Any background context you want to provide?

In the yorkie-js-sdk, detaching a document should ideally stop the process of sending PushPullChanges requests, ensuring that only relevant and active documents trigger these requests.
before sending request change DocumentStatus detached.

What are the relevant tickets?

Checklist

  • Added relevant tests or not required
  • Didn't break anything

@rappire
Copy link

rappire commented Aug 3, 2024

I found a bug and want to fix it, but I couldn't because it's an issue with the yorkie-js-sdk

@devleejb
Copy link
Member Author

devleejb commented Aug 4, 2024

Related to #220

@devleejb
Copy link
Member Author

devleejb commented Aug 4, 2024

@hackerwins
May I ask for your opinion?

@hackerwins
Copy link
Member

I found a bug and want to fix it, but I couldn't because it's an issue with the yorkie-js-sdk

It looks like this will have to be resolved in the JS SDK. and we are working on yorkie-team/yorkie-js-sdk#856.

@jeonghye-choi @rappire
Could we work together?

@rappire
Copy link

rappire commented Aug 5, 2024

I want to try to solve this problem, but jeonghye-choi is already in charge, can I work on it?

@devleejb
Copy link
Member Author

@rappire
Sorry for late check. I will assign you.

@sejongk
Copy link

sejongk commented Sep 29, 2024

As @hackerwins mentioned, this issue should be resolved in the JS SDK.
I think it seems better to work together with @gwbaik9717 in the issue of the JS SDK (yorkie-team/yorkie-js-sdk#856).
cc. @rappire, @devleejb

@devleejb devleejb moved this from Backlog to In progress in CodePair Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 Something isn't working
Projects
Status: In progress
Development

No branches or pull requests

4 participants