-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error occurs when clicking back button in the document - "document not attached" #146
Comments
TitleFix issue with continuous PushPullChanges requests after detaching document ContentWhat this PR does / why we need it?This PR addresses a bug where continuous PushPullChanges requests are sent even after detaching a document, causing errors in the process. The issue occurs when navigating back triggers the document detach process. In the yorkie-js-sdk, when editing a document, PushPullChanges requests are sent at specified intervals. However, the problem arises when detaching a document in the sdk. Despite the detach operation, the loop responsible for sending PushPullChanges requests is not terminated. As a result, the yorkie server receives requests for a detached document, leading to errors. Once an error occurs, the loop is terminated, preventing further issues from arising. Any background context you want to provide?In the yorkie-js-sdk, detaching a document should ideally stop the process of sending PushPullChanges requests, ensuring that only relevant and active documents trigger these requests. What are the relevant tickets?Checklist
|
I found a bug and want to fix it, but I couldn't because it's an issue with the yorkie-js-sdk |
Related to #220 |
@hackerwins |
It looks like this will have to be resolved in the JS SDK. and we are working on yorkie-team/yorkie-js-sdk#856. @jeonghye-choi @rappire |
I want to try to solve this problem, but jeonghye-choi is already in charge, can I work on it? |
@rappire |
As @hackerwins mentioned, this issue should be resolved in the JS SDK. |
What happened:
When clicking the back button in the document, an error message stating "document not attached" is displayed.
What you expected to happen:
Clicking the back button should navigate to the previous page without any error message.
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
The error message occurs consistently whenever the back button is clicked.
Environment:
The text was updated successfully, but these errors were encountered: