Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Problems in DistillationBox #471

Closed
1396066796 opened this issue May 26, 2024 · 2 comments
Closed

[BUG] Problems in DistillationBox #471

1396066796 opened this issue May 26, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@1396066796
Copy link

1396066796 commented May 26, 2024

Please use Discussions to ask questions.

Describe the bug
A clear and concise description of what the bug is.

In DistillationBox, the class instantiates the AuxiliaryModelWrapper before placing the model in DataParallel. I am attaching a screenshot below.

To Reproduce
Provide
Whether or not you made any changes in Python code (if so, how you made the changes?) none lib file changed
Project files
srd.zip

Expected behavior
A clear and concise description of what you expected to happen.

Environment (please complete the following information):

  • OS: [Ubuntu 20.04 LTS]
  • Python ver. [3.9]
  • torchdistill ver. [lasted]

Additional context
ef74033aaf1b388412b6734623947a4

754c85d6e5ad615a2a6eaa869a184fe

f6e33c006bd1bc47be3601bcee7c2ea

065d4f5039b1ff9dedbaa6daea58710

@1396066796 1396066796 added the bug Something isn't working label May 26, 2024
@yoshitomo-matsubara
Copy link
Owner

Hi @1396066796

Thank you for the issue.
The AuxiliaryModelWrapper should be wrapped by wrapper: DataParallel, and it looks like the config is incorrect. I'm fixing it now

@yoshitomo-matsubara
Copy link
Owner

It is not a bug in code, but in the config file. I updated the sample config file in the above PR.
For the official SRD config, I will work with @roymiles in a separate PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants