Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

human-panic swallows helpful error message #16

Open
danreeves opened this issue Sep 20, 2018 · 4 comments
Open

human-panic swallows helpful error message #16

danreeves opened this issue Sep 20, 2018 · 4 comments

Comments

@danreeves
Copy link
Collaborator

Bug Report

Your Environment

Software Version(s)
crossgen 0.5.0
Rustc rustc 1.30.0-nightly (20dc0c507 2018-09-19)
Operating System macOS

Expected Behavior

When you're missing the repository field from Cargo.toml you should receive the error No repository found in Cargo.toml.

Current Behavior

You get human-panic output pointing to an error report, nether of which contain any reference to the original error message which comes from here:

.expect("No repository found in Cargo.toml");

@yoshuawuyts
Copy link
Owner

@danreeves yeah agree this ought to be fixed. Issue about it is open here rust-cli/human-panic#40. A PR to fix this on human-panic would be great!

cc/ @spacekookie ping, figure you might be interested in this too.

@stale
Copy link

stale bot commented Dec 20, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Dec 20, 2018
@spacekookie
Copy link
Contributor

@yoshuawuyts can you please configure your bot to be less pessimistic? 😂

@stale stale bot removed the wontfix This will not be worked on label Dec 20, 2018
@yoshuawuyts
Copy link
Owner

yoshuawuyts commented Dec 22, 2018

@spacekookie lol, sure.

We should probably update this file to also include feature and bug reports. https://github.com/yoshuawuyts/crossgen/blob/master/.github/stale.yml#L3-L7.

As an aside: github templates now also include a way to auto-label issues created with a certain template, so that should hopefully allow us to smoothen out the pipeline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants