Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all unit test for Luxon #59

Merged
merged 2 commits into from
Oct 29, 2018
Merged

Add all unit test for Luxon #59

merged 2 commits into from
Oct 29, 2018

Conversation

cylim
Copy link
Member

@cylim cylim commented Oct 29, 2018

closes #26

@coveralls
Copy link

Pull Request Test Coverage Report for Build 155

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 154: 0.0%
Covered Lines: 43
Relevant Lines: 43

💛 - Coveralls

2 similar comments
@coveralls
Copy link

Pull Request Test Coverage Report for Build 155

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 154: 0.0%
Covered Lines: 43
Relevant Lines: 43

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 155

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 154: 0.0%
Covered Lines: 43
Relevant Lines: 43

💛 - Coveralls

Copy link
Member

@stevemao stevemao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job!

@stevemao stevemao merged commit 857685f into you-dont-need:master Oct 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

You should add Luxon, moment.js' alternative to itself
3 participants