Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update library version #79

Closed
wants to merge 5 commits into from
Closed

update library version #79

wants to merge 5 commits into from

Conversation

cylim
Copy link
Member

@cylim cylim commented Aug 21, 2019

close #78

Generally, most benchmark is getting worse due to my laptop is not as powerful as the one used to perform the test previously

@coveralls
Copy link

coveralls commented Aug 21, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 197

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 195: 0.0%
Covered Lines: 43
Relevant Lines: 43
💛 - Coveralls

@stevemao
Copy link
Member

Could you also remove

Note that the provided examples of date-fns are for v2 which is in pre-release right now. See v1 docs for the current release.

@cht8687 cht8687 self-requested a review August 22, 2019 00:55
@cht8687
Copy link
Member

cht8687 commented Aug 22, 2019

Good work!

@stevemao
Copy link
Member

@cylim Why is screenshot.png deleted?

@cylim
Copy link
Member Author

cylim commented Aug 22, 2019

@cylim Why is screenshot.png deleted?

@stevemao replaced, not deleted. The reason is upgrading libraries will affect the sizes. I can change it back if wanted to keep the original.

@stevemao
Merge pull request #79 from cylim/master
a2a8b43 
update library version
@stevemao
Copy link
Member

Sorry, I thought it was deleted. Thanks for the PR

@cylim cylim closed this Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cht8687 cht8687 cht8687 approved these changes

@stevemao stevemao stevemao approved these changes

@andrew-yangy andrew-yangy andrew-yangy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Date-fns v2 is officially released
5 participants
@cylim @coveralls @stevemao @cht8687 @andrew-yangy