Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linked Moment Tests don't support bugs argument? #87

Closed
micnguyen opened this issue Feb 19, 2020 · 2 comments
Closed

Linked Moment Tests don't support bugs argument? #87

micnguyen opened this issue Feb 19, 2020 · 2 comments
Assignees

Comments

@micnguyen
Copy link

In the README, there's a line that says It is mutable due to OOP APIs and non-pure functions, which cause bugs: with a link to https://github.com/moment/moment/blob/develop/src/test/moment/add_subtract.js#L244-L286

I'm looking at these tests and I can't seem to pin point why these tests might support the line which cause bugs. Sure, the API is a bit verbose and it is OOP vs pure, but I don't think it's buggy.

@stevemao
Copy link
Member

I did a git blame and saw @ddvkid wrote that line.

@andrew-yangy
Copy link
Member

Good catch, I will make an update on that, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants