Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output missing for pyproject.toml #158

Closed
iamgodot opened this issue Feb 7, 2023 · 4 comments
Closed

Output missing for pyproject.toml #158

iamgodot opened this issue Feb 7, 2023 · 4 comments

Comments

@iamgodot
Copy link

iamgodot commented Feb 7, 2023

Hi, I'm using pyproject.toml for configuration, and it seems like the output message does not include the change of this file. I guess it works fine for the case of tbump.toml so there could be an easy fix?

@dmerejkowsky
Copy link
Collaborator

I can't reproduce the bug here ... Do you have some code you could share ?

@iamgodot
Copy link
Author

The output is as the following:

❯ tbump 0.7.1
:: Bumping from 0.7.0 to 0.7.1
=> Would update current version in pyproject.toml
=> Would patch these files
- src/py_tldr/__init__.py:4 __version__ = "0.7.0"
+ src/py_tldr/__init__.py:4 __version__ = "0.7.1"
...

I was expecting the diff of pyproject.toml to be listed just as __init__.py. While on second thought, maybe this was by your design. Should I close the issue?

@dmerejkowsky
Copy link
Collaborator

Oh I got it - we have a test for this, but it looks like that:

# same as in your project
[[tool.tbump.file]]
src = "foo/__init__.py"
search = '__version__ = "{current_version}"'

# but here we also add pyproject.toml explicitly:
[[tool.tbump.file]]
src = "pyproject.toml"
search = 'version = "{current_version}"'

So - your issue is valid and asks a good question - I was thinking that the message "Would update current version in pyproject.toml" was enough, but I'm obviously biased ;)

What do you think?

@dmerejkowsky dmerejkowsky changed the title Output seems missing for pyproject.toml Output missing for pyproject.toml Mar 16, 2023
@dmerejkowsky
Copy link
Collaborator

Note: this is actually a duplicate of #145, so closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants