-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All exceptions are caught #97
Comments
@rovansteen Will let it slip in Symfony bundle. Ideally – exceptions will be delivered with the descriptive information so you can easily see what's the problem is. That was a big topic of discussion and idea was to return response in any case... but again, we have to keep the original exception message if it's generic. |
@viniychuk yes I understand that. Perhaps having some sort of middleware where you can do something with the exception, like log it or send it to a service like Sentry will help with debugging a lot while still being able to send a useful response back to the client. |
Just a workaround: I've written my own ExecutionContext class and invoke it via the given parameter "graphql.execution_context.class". This way I can override the "addError" method and log accordingly. |
This issue makes testing and debugging really difficult. It seems like there are lots of places where |
Why are all the exceptions caught? This makes debugging really difficult, because there will be no logs or for example in my Symfony application nothing shows up in the profiler. Am I missing something here?
The text was updated successfully, but these errors were encountered: