Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to .NET 6 RC2 #6

Merged
merged 6 commits into from
Nov 2, 2021
Merged

Upgrade to .NET 6 RC2 #6

merged 6 commits into from
Nov 2, 2021

Conversation

dominik-oktav
Copy link
Collaborator

Fix compilation errors:

  • Expose internals of DistributedResponseCachingMiddleware to DistributedResponseCachingMiddlewareTests. This fixes Improved MS reference from new code #5.
  • Consider new namespace of CachedResponse

Upgradef to NET 6 RC2:

  • Set target framework to net6.0
  • Updated nuget packages to 6.0 or latest
  • Set Version to 6.0.0-rc2

Bugfixes:

  • Register ResponseCachingPolicyProvider as IResponseCachingPolicyProvider when CacheAuthorizedRequest is not enabled, to fix error when resolving for IResponseCachingPolicyProvider
  • Fix configuration of ResponseCachingOptions by configuring it explicitly. By just registering the CustomResponseCachingOptions, the options of the base objects would get lost when resolving for IOptions.

dominik-oktav and others added 6 commits October 14, 2021 17:16
- Expose internals of DistributedResponseCachingMiddleware to DistributedResponseCachingMiddleware DistributedResponseCachingMiddlewareTests
- Consider new namespace of CachedResponse
…der, when CacheAuthorizedRequest is not enabled, to fix error when resolving IResponseCachingPolicyProvider
- Set target framework to net6.0
- Updated nuget packages to 6.0 or latest
- Set Version to 6.0.0-rc2
…tly. By just registering the CustomResponseCachingOptions, the options of the base objects would get lost when resolving for IOptions<ResponseCachingOptions>.
Fix configuration of ResponseCachingOptions
@yringler yringler merged commit 3503643 into yringler:master Nov 2, 2021
@yringler
Copy link
Owner

yringler commented Nov 2, 2021

This looks great, thank you!
Merged, will try to update the nuget package later today.
Would you be able to update the documentation (Readme) also?

Also, I'm not using this package; it would be better if it was maintained by someone who's using it.
Would you be interested in being added as maintainer?
I could even see about having you able to upload builds to nuget.

@dominik-oktav
Copy link
Collaborator Author

Thanks for the offer, I gladly would be maintainer of this project. This would make it much easier for us to make future changes if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improved MS reference from new code
2 participants