Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to poetry and auto-install Eigen #10

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Switch to poetry and auto-install Eigen #10

wants to merge 5 commits into from

Conversation

hippalectryon-0
Copy link

Changes:

  • use poetry instead of setup.py, which is more practical, has better dependency support, and doesn't rely in hardcoding setup.py
  • change setup.py into build.py accordingly, remove parts made redundant by poetry
  • Fix Eigen path spec is deprecated #9 by adding a usr_include = "" in pyproject.toml
  • Add an optional (true by default) automatic installation of Eigen headers through auto_install = true in pyproject.toml
  • Change the name to lowercase to comply with PEP8

The installation via poetry install (which replaces python setup.py install) works on my system.
Caveats:

  • I have only performed the installation on windows (MSVC)
  • I have only performed the installation within a virtualenv
  • I have not performed extensive testing of the installed library, since this repo does not provide a minimal python file or unit tests

@hippalectryon-0
Copy link
Author

Update: I have tried on Linux and the Eigen auto-install doesn't work there. I'm marking the PR as Draft until I fix that.

@hippalectryon-0 hippalectryon-0 changed the title Switch to poetry and auto-install Eigen Draft: Switch to poetry and auto-install Eigen Oct 22, 2023
@hippalectryon-0 hippalectryon-0 marked this pull request as draft October 22, 2023 16:49
@hippalectryon-0 hippalectryon-0 changed the title Draft: Switch to poetry and auto-install Eigen Switch to poetry and auto-install Eigen Oct 24, 2023
@hippalectryon-0
Copy link
Author

Linux install works fine now (tested @ubuntu22)

@hippalectryon-0 hippalectryon-0 marked this pull request as ready for review October 24, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Eigen path spec is deprecated
1 participant
@hippalectryon-0