Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ie/XiaoHongShu] Extract more formats #12147

Merged
merged 4 commits into from
Jan 20, 2025

Conversation

seproDev
Copy link
Member

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

Extract source formats and fix bitrate calculation

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

@seproDev seproDev added the site-enhancement Feature request for some website label Jan 20, 2025
@seproDev seproDev requested a review from Copilot January 20, 2025 17:23

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

yt_dlp/extractor/xiaohongshu.py Outdated Show resolved Hide resolved
Copy link
Contributor

@DTrombett DTrombett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I think on line 50 ('h264', 'av1', 'h265') can be replaced with ... so that it works with other formats, if added, too

yt_dlp/extractor/xiaohongshu.py Outdated Show resolved Hide resolved
seproDev and others added 2 commits January 20, 2025 19:47
Co-authored-by: bashonly <88596187+bashonly@users.noreply.github.com>
@seproDev seproDev changed the title [ie/XiaoHongShu] Improvements [ie/XiaoHongShu] Extract more formats Jan 20, 2025
@seproDev seproDev merged commit f9f24ae into yt-dlp:master Jan 20, 2025
6 checks passed
@seproDev seproDev deleted the XiaoHongShu-improvements branch January 20, 2025 18:55
vladisslav2011 pushed a commit to vladisslav2011/yt-dlp that referenced this pull request Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site-enhancement Feature request for some website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants