[youtube:tab] Detect looping feeds #6621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
issue: first page is still repeated due to no continuation |
pukkandan
force-pushed
the
master
branch
2 times, most recently
from
ee280c7 to
7aeda6c
Compare
10 tasks
|
@coletdjnz @pukkandan 👋 friendly bump - Can we get this merged since it's still a valid bug with no workarounds on the the following URLs? (any auto-generated music channel that doesn't have a /releases tab) |
@coletdjnz Is this the only issue? If so, we can merge it imo. It's better than nothing |
aalsuwaidi
pushed a commit
to aalsuwaidi/yt-dlp
that referenced
this pull request
Apr 21, 2024
Closes yt-dlp#5555 Note: the first page may still be repeated, however this is better than nothing. Authored by: coletdjnz
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
ADD DESCRIPTION HERE
Fixes #5555
YouTube is rolling out a change where they loop (channel?) feeds at the end. Fortunately the continuations appear to be identical, so we can detect when it loops using those.
#5555 (comment)
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?
🤖 Generated by Copilot at 4e53d87
Summary
🐛📺🔀
Fix infinite loop bug in YouTube feed extraction. Use a set to track seen continuation tokens in
yt_dlp/extractor/youtube.py.Walkthrough