Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update piapro tests and content url scheme #7592

Merged
merged 3 commits into from
Jul 14, 2023

Conversation

FinnRG
Copy link
Contributor

@FinnRG FinnRG commented Jul 14, 2023

Description of your pull request and other information

Fixes #

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

Copilot Summary

🤖 Generated by Copilot at b7b94b7

Summary

🆕🛠📝

Improve piapro extractor functionality and tests. Support new URL formats, add more metadata fields, and update test cases for piapro.py.

piapro extracts
more URLs and info fields
autumn of updates

Walkthrough

  • Update _VALID_URL regex to match both /t/ and /content/ URLs for piapro.jp (link)
  • Extract more info fields from the webpage, such as description, duration, timestamp, upload_date, view_count, and thumbnail using _html_search_regex and _parse_json methods (link, link)
  • Update md5 checksum and add cookies field for the first test case in yt_dlp/extractor/piapro.py (link)

@pukkandan pukkandan added the site-enhancement Feature request for some website label Jul 14, 2023
yt_dlp/extractor/piapro.py Outdated Show resolved Hide resolved
yt_dlp/extractor/piapro.py Outdated Show resolved Hide resolved
@pukkandan pukkandan merged commit 1bcb9fe into yt-dlp:master Jul 14, 2023
@FinnRG FinnRG deleted the fix/piapro branch July 14, 2023 18:09
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site-enhancement Feature request for some website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants