-
-
Notifications
You must be signed in to change notification settings - Fork 7.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix n-tv.de extractor, website format has changed #8414
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seproDev
requested changes
Nov 2, 2023
seproDev
approved these changes
Nov 5, 2023
seproDev
added
pending-review
PR needs a review
and removed
pending-fixes
PR has had changes requested
labels
Nov 10, 2023
bashonly
requested changes
Nov 11, 2023
bashonly
added
pending-fixes
PR has had changes requested
and removed
pending-review
PR needs a review
labels
Nov 11, 2023
Co-authored-by: bashonly <88596187+bashonly@users.noreply.github.com>
Add additional test case.
bashonly
approved these changes
Nov 11, 2023
aalsuwaidi
pushed a commit
to aalsuwaidi/yt-dlp
that referenced
this pull request
Apr 21, 2024
Closes yt-dlp#3179 Authored by: 1100101
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
As the website format has been changed for videos on n-tv.de, the extractor was broken and could not download videos anymore.
Fixes #3179
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?
Copilot Summary
🤖 Generated by Copilot at 1dbb4bb
Summary
🛠️🆕🧪
Fix and improve
ntvde
extractor. Usetraverse_obj
to handle JSON data and add support for new formats. Update test case with new video.Walkthrough
traverse_obj
function fromutils
module to access nested values in JSON data (link)html5VideoPoster
toposter
inyt_dlp/extractor/ntvde.py
(link)