Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed key error for like_count #8763

Merged
merged 4 commits into from
Dec 13, 2023

Conversation

pandeyganesha
Copy link
Contributor

@pandeyganesha pandeyganesha commented Dec 12, 2023

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

Issue #8759 mentions, "No longer extracting like_count for video metadata". It was happeing because vpir did not have the values of like and dislike counts where it was specified. So that was returning None value while int was expected.

Fixes #

So I updated the reference to the correct place of likes and the problems is solved. The test case is passing

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

yt_dlp/extractor/youtube.py Outdated Show resolved Hide resolved
@bashonly bashonly added site-bug Issue with a specific website pending-fixes PR has had changes requested labels Dec 12, 2023
@bashonly bashonly removed the pending-fixes PR has had changes requested label Dec 13, 2023
@bashonly bashonly merged commit 6b5d93b into yt-dlp:master Dec 13, 2023
15 checks passed
@pandeyganesha pandeyganesha deleted the bugfix/like-count-keyerror-fix branch December 13, 2023 07:43
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site-bug Issue with a specific website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants