Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize arguments to plot annotations #547

Closed
yt-fido opened this issue Apr 15, 2013 · 5 comments
Closed

Standardize arguments to plot annotations #547

yt-fido opened this issue Apr 15, 2013 · 5 comments
Labels
enhancement Making something better help wanted Contributions from external projects' maintainers is particularly appreciated ! viz: 2D

Comments

@yt-fido
Copy link
Collaborator

yt-fido commented Apr 15, 2013

Originally reported by: Matt Turk (Bitbucket: MatthewTurk, GitHub: MatthewTurk)

plot_args and text_args should only be one or the other. Having multiple argument names is confusing.
@yt-fido
Copy link
Collaborator Author

yt-fido commented Oct 16, 2014

Original comment by chummels (Bitbucket: chummels, GitHub: chummels):

Removing milestone: 3.1 (automated comment)

@yt-fido
Copy link
Collaborator Author

yt-fido commented Mar 24, 2016

Original comment by chummels (Bitbucket: chummels, GitHub: chummels):

There are a number of *_args keywords in the PlotAnnotations, including text_args, plot_args, circle_args, etc. While I understand your desire to have homogeneity in the kwargs of the various callbacks, I'm apprehensive because we confuse the user a bit as each callback potentially deals with different MPL objects (annotate_sphere -> MPL circles, annotate_arrow -> MPL arrow, annotate_text -> MPL text, etc.). While I largely agree with the issue, I think this needs more discussion.

@yt-fido yt-fido added this to the easy milestone Apr 20, 2017
@ngoldbaum ngoldbaum added help wanted Contributions from external projects' maintainers is particularly appreciated ! enhancement Making something better and removed major bug labels May 3, 2017
@ngoldbaum ngoldbaum removed this from the easy milestone May 3, 2017
@ngoldbaum ngoldbaum removed the yt label May 3, 2017
@ngoldbaum ngoldbaum modified the milestone: 3.4 May 4, 2017
@ngoldbaum ngoldbaum removed the 3.4 label May 4, 2017
@ngoldbaum ngoldbaum modified the milestones: 3.4, 4.0 May 17, 2017
@neutrinoceros neutrinoceros mentioned this issue Jul 26, 2020
Open
@neutrinoceros neutrinoceros mentioned this issue Jan 19, 2021
Closed
@neutrinoceros neutrinoceros modified the milestones: 4.0, 4.1.0 Oct 24, 2021
@neutrinoceros
Copy link
Member

neutrinoceros commented Oct 24, 2021 •
edited
Loading

remilestoned, hoping we can discuss and/or resolve this before 4.1, but it should never block that release.

@neutrinoceros neutrinoceros removed this from the 4.1.0 milestone May 22, 2022
@neutrinoceros
Copy link
Member

@matthewturk I'm considering closing this after #3957 went in. Thoughts ?

@matthewturk
Copy link
Member

yup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Making something better help wanted Contributions from external projects' maintainers is particularly appreciated ! viz: 2D
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ENH: uniformize mpl_kwargs neutrinoceros/yt
4 participants
@matthewturk @ngoldbaum @neutrinoceros @yt-fido