Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown Component in flex div can exceed the width of the plugin window #101

Closed
aashreys opened this issue May 14, 2022 · 2 comments
Closed
Labels
bug Something isn't working v2

Comments

@aashreys
Copy link

Encountering another Dropdown component related issue as shown in the video below.

dropdown.issue.mov

Seems like the dropdown doesn't truncate text when it reaches the edge of the window. Here's the relevant HTML layout snippet:

    <div style='display: flex; width: 100%'>

          <Dropdown
          icon={this.getIcon(this.getUiValueFromConfig(navigation.device))}
          onChange={e => this.onDeviceChange(e.currentTarget.value)} 
          options={DEVICES} 
          value={this.getUiValueFromConfig(navigation.device)}
          noBorder />

          <Dropdown
          style={'flex-grow: 1'}
          icon={this.getIcon(this.getUiValueFromConfig(navigation.scheme))}
          onChange={e => this.onSchemeChange(e.currentTarget.value)} 
          options={navigation.device === Device.KEYBOARD ? KEYBOARD_OPTIONS : CONTROLLER_OPTIONS} 
          value={this.getUiValueFromConfig(navigation.scheme)}
          noBorder />

    </div>

Thanks so much for your help on the previous issues btw :)

@yuanqing
Copy link
Owner

Should be fixed in next. Can you verify locally @aashreys?

@yuanqing yuanqing added the bug Something isn't working label May 15, 2022
@yuanqing
Copy link
Owner

yuanqing commented Jun 6, 2022

This will be fixed in 2.0.0

@yuanqing yuanqing added the v2 label Jun 9, 2022
@yuanqing yuanqing closed this as completed Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v2
Projects
None yet
Development

No branches or pull requests

2 participants