Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disclosure click target #128

Closed
abynim opened this issue Oct 28, 2022 · 5 comments
Closed

Disclosure click target #128

abynim opened this issue Oct 28, 2022 · 5 comments
Labels
bug Something isn't working

Comments

@abynim
Copy link

abynim commented Oct 28, 2022

I'm trying to use the Disclosure component with a button contained inside it. Currently the click target to toggle the Disclosure covers the entire area of the title and children, so the button inside is not clickable.

Is this by design, or should the Disclosure's click target be limited to only the title area?

@abynim
Copy link
Author

abynim commented Oct 28, 2022

I checked an older plugin that was using v1, and it seems this behavior changed at some point.

Here's the diff: 63c01a5#diff-9ce5ac9e0fc8ce8773449882f71c8adb86bd278f628c295310d4280f4c3a2dea

@yuanqing
Copy link
Owner

Can confirm that this is a bug

@yuanqing yuanqing added the bug Something isn't working label Oct 28, 2022
@yuanqing
Copy link
Owner

@abynim – I just cut a @create-figma-plugin/ui@2.1.5-alpha.0. Can you verify if it fixes the issue?

@abynim
Copy link
Author

abynim commented Oct 31, 2022

Just checked. Works as expected 👍 Thanks for the quick fix, will look out for the official update!

@yuanqing
Copy link
Owner

yuanqing commented Nov 4, 2022

Fixed in 2.1.5

@yuanqing yuanqing closed this as completed Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants