Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

defaultSettings is mutated in loadSettingsAsync #79

Closed
yuanqing opened this issue Jan 27, 2022 · 1 comment
Closed

defaultSettings is mutated in loadSettingsAsync #79

yuanqing opened this issue Jan 27, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@yuanqing
Copy link
Owner

create-figma-plugin/packages/utilities/src/settings.ts

Line 19 in 1a276ea

return Object.assign(defaultSettings, settings)

The fix is:

 return Object.assign({}, defaultSettings, settings)
@yuanqing yuanqing added the bug Something isn't working label Jan 27, 2022
@yuanqing yuanqing self-assigned this Jan 27, 2022
@yuanqing
Copy link
Owner Author

yuanqing commented Feb 1, 2022

Fixed in 1.8.3

@yuanqing yuanqing closed this as completed Feb 1, 2022
@yuanqing yuanqing removed their assignment May 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yuanqing