Do not inject setState/ref into dependencies

[Glinkis]

Currently testing this macro, so far with great success!

But I have one minor nitpick.

Currently this:

const [state, setState] = useState(0)
useAutoEffect(() => {
   setState(1)
})

Is converted to:

const [state, setState] = useState(0)
useEffect(() => {
   setState(1)
}, [setState])

But adding setState to the dependency array is redundant, since react guarantees it to be referentially stable. The same is true for useRef.

The react-hooks/exhaustive-deps eslint takes both of them into consideration.

[yuchi]

This is a very nice suggestion! We could also exclude:

1. the state value if the setter is never used
2. memoized values/callbacks that use an empty dependencies array

[Glinkis]

Thanks for the response!
I'm not sure I quite understand your suggestions. It would be awesome if you could show an example of each of them.

[yuchi]

function MyComponent() {
  const [id] = React.useState(() => Math.random());

  // Doesn’t require [id] since it will never change
  useAutoEffect(() => {
    console.log(id);
  });

  const [counter, setCounter] = React.useState(0);

  // Again, `setCounter` is not used, `counter` will never change!
  const values = useAutoMemo(new Array(counter));

  const handleLog = React.useCallback(() => {}, []);

  // `handleLog` will (*should*) never change, using as a dependency is reduntant
  useAutoEffect(() => handleLog('Hallo!'));
}

[yuchi]

Found the relative code in the ESLint exhaustive-deps rules: https://github.com/facebook/react/blob/fe2cb525542443aaf1447c4069354c12659fd186/packages/eslint-plugin-react-hooks/src/ExhaustiveDeps.js#L296

Should be straight forward to add them to this macro.

[yuchi]

Please see #11 and #12 for further discussion on those additional optimizations.

[yuchi]

@Glinkis you can see this implemented in v1.1.0. Should bring those small perf improvements :)

[Glinkis]

Thanks!