Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DocDB] RBS: Add retries around FetchData to mask intermittent network failures #26217

Open
1 task done
amitanandaiyer opened this issue Feb 27, 2025 · 0 comments
Open
1 task done
Assignees
Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue

Comments

@amitanandaiyer
Copy link
Contributor

amitanandaiyer commented Feb 27, 2025

Jira Link: DB-15563

Description

https://phorge.dev.yugabyte.com/diffusion/YBDB/browse/master/src/yb/tserver/remote_bootstrap_file_downloader.cc$199

Currently in DownloadFile
we do


    FetchDataResponsePB resp;
    auto status = rate_limiter->SendOrReceiveData([this, &req, &resp, &controller]() {
      return proxy_->FetchData(req, &resp, &controller);
    }, [&resp]() { return resp.ByteSize(); });
    RETURN_NOT_OK_UNWIND_PREPEND(status, controller, "Unable to fetch data from remote");

which essentially fails the whole RBS session if there is any intermittent network error during FetchData.

We could add some retries around this to make the RBS more resilient to intermittent errors.

Issue Type

kind/enhancement

Warning: Please confirm that this issue does not contain any sensitive information

  • I confirm this issue does not contain any sensitive information.
@amitanandaiyer amitanandaiyer added area/docdb YugabyteDB core features status/awaiting-triage Issue awaiting triage labels Feb 27, 2025
@yugabyte-ci yugabyte-ci added kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue labels Feb 27, 2025
@yugabyte-ci yugabyte-ci removed the status/awaiting-triage Issue awaiting triage label Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue
Projects
None yet
Development

No branches or pull requests

3 participants