ysql: don't persist table_oid reloption #9003
Labels
area/ysql
Yugabyte SQL (YSQL)
kind/disk-format-change
This feature will change the on-disk format.
kind/enhancement
This is an enhancement of an existing feature
priority/medium
Medium priority issue
Jira Link: [DB-385](https://yugabyte.atlassian.net/browse/DB-385)
The
table_oid
reloption is not something that needs to be persisted topg_class
because it is only used at create time. IntransformRelOptions
, theoids
reloption can be stripped out ifignoreOids
is true (@frozenspider pointed this out to me). Similarly, we can always strip outtable_oid
options (and any others if appropriate).DefineIndex
callstransformRelOptions
so thatstmt->options
holds the old options before transformation andreloptions
holds the new options. Therefore, we can still readtable_oid
from the old options aftertransformRelOptions
, though I think it may be cleaner to stop using it aftertransformRelOptions
.However, watch out for compatibility with existing clusters that may already have useless
table_oid
reloptions persisted.Also, it could be useful to know that the table was created with the
table_oid
option, but I can't come up with any reasons. If there is a reason, this issue is invalid. cc: @hulien22The text was updated successfully, but these errors were encountered: