History Hash's parseHash() does not handle blank values #1116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rgrove new pull with your suggested changes. |
|
@blzaugg 👍 Looks good to me, thanks! I'll leave this open for a while to allow other folks time to comment, then I'll merge if there are no further objections. |
| if (param.length > 1) { | ||
| params[decode(param[0])] = decode(param[1]); | ||
| } else { | ||
| params[decode(match)] = ''; |
There was a problem hiding this comment.
+1 for default to an empty string for the value.
|
LGTM. @blzaugg thanks for include tests and HISTORY updates, makes the merge nice and easy :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hash strings such as:
#foo=bar&baz=&qu=uxor#foo=bar&baz&qu=uxfail because_REGEX_HASHdoes not allow blank values.