Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

path.join() creates backslashes on windows machines #216

Closed
iexus opened this issue Mar 3, 2014 · 3 comments
Closed

path.join() creates backslashes on windows machines #216

iexus opened this issue Mar 3, 2014 · 3 comments
Labels

Comments

@iexus
Copy link
Contributor

iexus commented Mar 3, 2014

Creating a link from one class to another (whether through @uses or #crossLink) doesn't work when building on a windows machine.

path.join() which is used to concat the strings together generates backslashes instead of forward slashes as it's intended for file paths not urls. This is a feature of Node and not a bug as windows loves backslashes.

I notice chrome doesn't seem to care and corrects the url in the browser however firefox (and god knows IE) doesn't.

For example (in my convoluted test files) this is the url generated on a linked method:

http://localhost:3000/classes/..\classes\Shoes.html#method_checkLacesTied

@caridy
Copy link
Member

caridy commented Mar 4, 2014

/cc @juandopazo

@caridy caridy added the Bug label Mar 4, 2014
@juandopazo
Copy link
Member

@caridy PR #217 looks correct, but I need to test it.

@caridy
Copy link
Member

caridy commented Mar 8, 2014

@caridy caridy closed this as completed Mar 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants