Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generated html contains links to yahooapis.com #232

Open
noamtm opened this issue Apr 9, 2014 · 3 comments
Open

generated html contains links to yahooapis.com #232

noamtm opened this issue Apr 9, 2014 · 3 comments

Comments

@noamtm
Copy link

noamtm commented Apr 9, 2014

See theme.json in both the default and simple themes. As a result, generated documentation always accesses an external website (running this in a corporate environment), which is a security issue. It also delays loading time (which is the reason I noticed it).

The fix should probably be a local copy of these files (cssgrids-min.css and yui-min.js), added to the assets directory of the generated docs.

Until this is fixed, is there a way for me to locally fix it (preferably using a script or even modifying the installed package)? I can't deliver documentation like that.

@okuryu
Copy link
Member

okuryu commented Nov 20, 2014

I guess that you're able to avoid the problem by creating a theme, but I'll consider to revamp existing in the future.

@cibernox
Copy link

cibernox commented Apr 7, 2015

Same happened to me. Since I have an restrictive CSP policy, my app complains about yahooapis.com being an untrusted source. I can create a custom theme for now, but I leave my 👍 here for this to be changed.

@okuryu
Copy link
Member

okuryu commented Apr 7, 2015

You're able to bypass it by specifying yui.yahooapis.com as default src if you're in CSP restricting, right? Anyway, I feel that we should do something for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants