Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable custom entitlements #91

Closed
proohit opened this issue Mar 24, 2023 · 3 comments · Fixed by #93 or #96
Closed

Enable custom entitlements #91

proohit opened this issue Mar 24, 2023 · 3 comments · Fixed by #93 or #96

Comments

@proohit
Copy link

proohit commented Mar 24, 2023

Hi,

thanks for your awesome action. I'm trying to build an app using custom Configurations with entitlements in separate files. However, there is no option in the action to configure custom entitlement files. Fastlane supports entitlement files using the entitlements_file_path option in update_code_signing_settings (see http://docs.fastlane.tools/actions/update_code_signing_settings/#parameters).

I don't know if this is the exact attribute to control, but local builds in xCode work with no problems. The custom entitlement files are configured in xcode. How can I pass custom entitlements files to the action in order to be picked up in fastlane?

@dasheck0
Copy link
Contributor

dasheck0 commented Mar 25, 2023

As far as I can tell this action does not support custom entitlement files. See

update_code_signing_settings(
use_automatic_signing: false,
path: ENV['PROJECT_PATH'],
code_sign_identity: ENV['CODE_SIGNING_IDENTITY'],
targets: update_targets
)
There should be an option to provide custom parameters to the update_code_signing_settings function.

Another option is to run resign afterwards (see fastlane/fastlane#17727), but this seems like a hacky workaround.

@yukiarrr Is this repo still maintained?

@dasheck0
Copy link
Contributor

dasheck0 commented Mar 25, 2023

@yukiarrr Did it myself. See #93. Hope you merge it soon as it is a blocker for us. Let me know if you request some changes. Thanks!

@dungi
Copy link

dungi commented Mar 27, 2023

@dasheck0 I guess this feature broke my CI. Cause I have more than 1 entitlement file in my project (Main App, Widgets, WatchApp) the default value ("") would set all paths for the ".envirionment"-File to "", which is currently not what I need. If I set multiple paths, every target gets all 3 entitlements paths set. I need to revert to version 1.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment