Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0.3 Breaks cover letter headers and footers #71

Closed
Roukoswarf opened this issue Oct 20, 2024 · 2 comments · Fixed by #74
Closed

2.0.3 Breaks cover letter headers and footers #71

Roukoswarf opened this issue Oct 20, 2024 · 2 comments · Fixed by #74
Assignees
Labels
bug Something isn't working

Comments

@Roukoswarf
Copy link

Describe the bug
Between 2.0.2 and 2.0.3 the change in footer code also moved the letter header into the footer, causing the footer to flow off the end of the page, instead of being in the header.

To Reproduce

  1. Compile the example letter.typ
  2. View missing header, and the beginnings of the My Name at the bottom of the page.

Expected behavior
The original result which is produced by 2.0.2

Desktop:

  • OS: Linux
  • Typst Version: 0.12
  • Brilliant-CV Version: 2.0.3
@yunanwg
Copy link
Owner

yunanwg commented Oct 21, 2024

Thanks for submitting this bug @Roukoswarf! Yeah indeed it seems to me that there is an omission.

Will fix it ASAP.

@yunanwg yunanwg self-assigned this Oct 21, 2024
@yunanwg yunanwg added the bug Something isn't working label Oct 21, 2024
@yunanwg yunanwg moved this to WIP in brilliant-CV Oct 21, 2024
Repository owner deleted a comment Oct 24, 2024
@yunanwg yunanwg closed this as completed Nov 2, 2024
@github-project-automation github-project-automation bot moved this from WIP to Long Term in brilliant-CV Nov 2, 2024
@yunanwg yunanwg reopened this Nov 2, 2024
@yunanwg
Copy link
Owner

yunanwg commented Nov 2, 2024

Sorry for the oversight, I guessed I just shot at my foot 😅

I just patched the fix and will also package this one in the next update in Typst repository.

Thanks!

@yunanwg yunanwg closed this as completed Nov 2, 2024
@yunanwg yunanwg moved this from Long Term to Done! in brilliant-CV Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done!
Development

Successfully merging a pull request may close this issue.

2 participants