Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

So is this code actually working? #5

Open
mario98 opened this issue Jul 23, 2018 · 9 comments
Open

So is this code actually working? #5

mario98 opened this issue Jul 23, 2018 · 9 comments

Comments

@mario98
Copy link

mario98 commented Jul 23, 2018

So is this code actually working? Readme says "(should be re-uploaded)", What does that mean? Some people here report that this code is just memorizing training examples but does not generalize. Is this true?

Even worse than having no code is having code that is pretending to work but will just waste your time and then you have to implement it from scratch anyway...

@shashank3959
Copy link

@mario98
Hey, were you able to get this code working?

@YeolJ00
Copy link

YeolJ00 commented Apr 29, 2019

https://github.com/YeolJ00/mnist-svhn-transfer
I've edited the code to work and changed some functions to meet recent updates
I wanted to make a branch or a pull request in this repository but wasn't able to figure out how.

@EvaFlower
Copy link

@YeolJ00 Hi there, would you please point out the problem in this code and the change you made?

@YeolJ00
Copy link

YeolJ00 commented May 1, 2019

@EvaFlower Putting aside the deprecated functions,
data_loader.py had a single tranform format in get_loader() that normalizes a 3 channel image.
MNIST data is not a 3 channel image thus requires a seperate transform format
It would be nice if you would double check it for me

@EvaFlower
Copy link

@YeolJ00 Yeah, you are right. But it did not raise exceptional information when running the code. So maybe it has no influence.

@YeolJ00
Copy link

YeolJ00 commented May 6, 2019

@EvaFlower What do you mean by exceptional information? In what sense do you mean by it has no influence?

@EvaFlower
Copy link

@YeolJ00 I mean that I can run the code successfully without changing the transform for MNIST. So maybe here it just used the transform in the first channel and ignored others.

@YeolJ00
Copy link

YeolJ00 commented May 9, 2019

@EvaFlower Well good for you. I wasn't able to run the code without changing that part. I wonder what the difference was.

@zxkplus
Copy link

zxkplus commented Jan 4, 2021

I get a reasonable result, when set "--use_reconst_loss True" and "--use_labels True"。 the MINST's generator result is better than svhn's

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants