Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implementation problems here #7

Open
Ledzy opened this issue Feb 3, 2020 · 0 comments
Open

implementation problems here #7

Ledzy opened this issue Feb 3, 2020 · 0 comments

Comments

@Ledzy
Copy link

Ledzy commented Feb 3, 2020

I found two problems about the code.
First, the reconstruction loss should be L1 loss instead of L2, according to cycleGAN's paper.
Second, the generator and discriminator should update simutaneously, while in the code it firstly update discriminator and then use updated discriminator to update generator, which is wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant