-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add an option to store rclip DB alongside of the indexed images #36
Comments
Hi @josalhor! I like your suggestion. Right now, you can configure this by adding an environment variable to your export RCLIP_DATADIR=<path to your photos>/.rclip If we go this way by default, we will need to either search parent dirs for the database if you perform a query in a subdir or to keep lots of smaller indexes in every subdir. Having multiple smaller indexes will negatively impact the query time when you search in a parent directory. Maybe, going the first way will make more sense, given performance implications 🤔 |
This would work for a single directory, but if you have multiple disjoint directories that would not work!
I didn't actually imagine this in a recursive fashion with nested directories in mind. I was thinking purely about the idea of having multiple disjoint albums that you want to query and share separately. I wonder if we would need to implement to some kind of |
@josalhor, |
Hello!
I have noticed that
rclip
saves the database based on an environment variable or a system data directory:rclip/rclip/utils.py
Line 37 in 7ea2eed
Is there any reason why we can't configure rclip to save the database on the current directory ala git? If I am not mistaken, that would allow users to move/copy these folders and keep a database of the cached images. This would be really useful if someone managed their albums through a cloud platform, allowing them to also upload the database file and share it across devices.
The text was updated successfully, but these errors were encountered: