profile_bannerのURLを取得できるサイズの追加 #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User#getProfileBanner600x200URL(), User#getProfileBanner1500x500URL()
takke
reviewed
Sep 14, 2017
There was a problem hiding this comment.
missing "/"
"1500x500" のようになっていますが URL の組み立てに失敗しています。
例)https://pbs.twimg.com/profile_banners/8379212/13907201011500x500
"/1500x500" のように変更してください。
| @@ -428,6 +428,21 @@ public String getProfileBannerMobileRetinaURL() { | |||
| } | |||
|
|
|||
| @Override | |||
| public String getProfileBanner300x100URL() { | |||
| return profileBannerImageUrl != null ? profileBannerImageUrl + "300x100" : null; | |||
|
|
||
| @Override | ||
| public String getProfileBanner600x200URL() { | ||
| return profileBannerImageUrl != null ? profileBannerImageUrl + "600x200" : null; |
|
|
||
| @Override | ||
| public String getProfileBanner1500x500URL() { | ||
| return profileBannerImageUrl != null ? profileBannerImageUrl + "1500x500" : null; |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
取得できるprofile_bannerのURLに
300x100
600x200
1500x500
のサイズの追加