Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaks in angular-cli: 1.0.0-beta.22-1 #28

Closed
arfeifei opened this issue Dec 6, 2016 · 5 comments
Closed

breaks in angular-cli: 1.0.0-beta.22-1 #28

arfeifei opened this issue Dec 6, 2016 · 5 comments

Comments

@arfeifei
Copy link

arfeifei commented Dec 6, 2016

Error: CustomFormsModule is not an NgModule
at AotPlugin.getNgModuleMetadata (D:\Lab\Temp\MyProject\ng2\MyProject\node_modules@ngtools\webpack\src\plugin.js:332:19)
at D:\Lab\Temp\MyProject\ng2\MyProject\node_modules@ngtools\webpack\src\plugin.js:345:51
at Array.map (native)
at AotPlugin.extractLoadChildren (D:\Lab\Temp\MyProject\ng2\MyProject\node_modules@ngtools\webpack\src\plugin.js:343:14)
at D:\Lab\Temp\MyProject\ng2\MyProject\node_modules@ngtools\webpack\src\plugin.js:346:30
at Array.map (native)
at AotPlugin.extractLoadChildren (D:\Lab\Temp\MyProject\ng2\MyProject\node_modules@ngtools\webpack\src\plugin.js:343:14)
at AotPlugin._processNgModule (D:\Lab\Temp\MyProject\ng2\MyProject\node_modules@ngtools\webpack\src\plugin.js:272:38)
at D:\Lab\Temp\MyProject\ng2\MyProject\node_modules@ngtools\webpack\src\plugin.js:242:39
at process._tickCallback (internal/process/next_tick.js:103:7)

@intellix
Copy link
Contributor

intellix commented Dec 6, 2016

I think this is actually a bug with angular-cli itself. I'm having these issues for a couple of modules and I see a few people with the same complaints in angular-cli/issues

@ddavid67
Copy link

ddavid67 commented Dec 6, 2016

Same issue here. Is there a way to fix it myself before next cli release ?

@SylTi
Copy link

SylTi commented Dec 10, 2016

You can downgrade to 1.0.0-beta.21

@intellix
Copy link
Contributor

intellix commented Dec 18, 2016

Been told that it's not an issue with angular-cli, but the project people are trying to import. The problem with angular-cli at the moment is that it doesn't give you the error as to why something isn't regarded as an NgModule. I believe beta 23 will at least give a bit more insight as to why it doesn't like some modules.

This needs fixing in this repository, but as to why it doesn't like it, I guess we'll find out when we get our hands on 23

@manuelfink
Copy link

manuelfink commented Dec 19, 2016

As it read in angular/angular-cli#3426

Please also take in mind, when building a production build with --aot.. That export default doesn't work!

also it is mentioned that

This is something to do with the thirdparty library. They are not statically analyzable; basically they don't publish metadata.json files which we need to understand their modules or components.

Quick fix for now, downgrading to angular-cli 1.0.0-beta.21

Unluckily I do not have any experiences with building libs and metadata.json however I hope this helps resolving the issue quickly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants