Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unix listen sockets are not working #1508

Closed
nolange opened this issue Apr 11, 2023 · 1 comment
Closed

unix listen sockets are not working #1508

nolange opened this issue Apr 11, 2023 · 1 comment

Comments

@nolange
Copy link

nolange commented Apr 11, 2023

kroki implements Unix sockets as requested per #1329.

But apparently there is still some support missing,from my understanding some other part of the code still expects a TCP Connection.

Easy to reproduce:

podman run \
        --rm \
        --replace \
        --name kroki-base \
        -e KROKI_LISTEN=unix:///run/www.sock \
        --image-volume=tmpfs \
        docker.io/yuzutech/kroki

Result:

{
  "timestamp": "1681209620341",
  "level": "ERROR",
  "thread": "vert.x-eventloop-thread-0",
  "logger": "io.vertx.core.impl.launcher.commands.VertxIsolatedDeployer",
  "message": "Failed in deploying verticle",
  "context": "default",
  "exception": "java.lang.IllegalArgumentException: null
 at io.vertx.core.net.impl.transport.Transport.serverChannelFactory(Transport.java:194)
 at io.vertx.core.net.impl.AsyncResolveConnectHelper.doBind(AsyncResolveConnectHelper.java:37)
 at io.vertx.core.net.impl.TCPServerBase.lambda$listen$2(TCPServerBase.java:168)
 at io.vertx.core.impl.future.FutureImpl$3.onSuccess(FutureImpl.java:141)
 at io.vertx.core.impl.future.FutureBase.emitSuccess(FutureBase.java:60)
 at io.vertx.core.impl.future.FutureImpl.addListener(FutureImpl.java:196)
 at io.vertx.core.impl.future.PromiseImpl.addListener(PromiseImpl.java:23)
 at io.vertx.core.impl.future.FutureImpl.onComplete(FutureImpl.java:164)
 at io.vertx.core.impl.future.PromiseImpl.onComplete(PromiseImpl.java:23)
 at io.vertx.core.net.impl.TCPServerBase.listen(TCPServerBase.java:151)
 at io.vertx.core.net.impl.TCPServerBase.bind(TCPServerBase.java:94)
 at io.vertx.core.http.impl.HttpServerImpl.listen(HttpServerImpl.java:215)
 at io.vertx.core.http.impl.HttpServerImpl.listen(HttpServerImpl.java:228)
 at io.kroki.server.Server.start(Server.java:164)
 at io.kroki.server.Server.lambda$start$1(Server.java:70)
 at io.vertx.core.impl.future.FutureImpl$3.onSuccess(FutureImpl.java:141)
 at io.vertx.core.impl.future.FutureBase.emitSuccess(FutureBase.java:60)
 at io.vertx.core.impl.future.FutureImpl.addListener(FutureImpl.java:196)
 at io.vertx.core.impl.future.FutureImpl.onComplete(FutureImpl.java:164)
 at io.vertx.config.impl.ConfigRetrieverImpl.getConfig(ConfigRetrieverImpl.java:175)
 at io.kroki.server.Server.start(Server.java:66)
 at io.vertx.core.impl.DeploymentManager.lambda$doDeploy$5(DeploymentManager.java:196)
 at io.vertx.core.impl.ContextInternal.dispatch(ContextInternal.java:264)
 at io.vertx.core.impl.ContextInternal.dispatch(ContextInternal.java:246)
 at io.vertx.core.impl.EventLoopContext.lambda$runOnContext$0(EventLoopContext.java:43)
 at io.netty.util.concurrent.AbstractEventExecutor.runTask(AbstractEventExecutor.java:174)
 at io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:167)
 at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:470)
 at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:569)
 at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:997)
 at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
 at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
 at java.base/java.lang.Thread.run(Unknown Source)
"
}
@ggrossetie
Copy link
Member

I believe this is a duplicate of #1441

@ggrossetie ggrossetie closed this as not planned Won't fix, can't repro, duplicate, stale Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants