Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depend on rcrowley/go-metrics #24

Open
jszwedko opened this issue Nov 13, 2014 · 4 comments
Open

Depend on rcrowley/go-metrics #24

jszwedko opened this issue Nov 13, 2014 · 4 comments

Comments

@jszwedko
Copy link

Is there a reason this library depends on a fork of go-metrics? Would it be possible to contribute the 2 commits upstream?

It would be nice to depend on the canonical go-metrics as the fork keeps falling behind.

@yvasiyarov
Copy link
Owner

@jszwedko before I can switch to origin go-metrics I need one more pull request to be accepted - rcrowley/go-metrics#92
Once it will be done - I will switch to original go-metrics

@jszwedko
Copy link
Author

👍 thanks for opening that PR!

@atedja
Copy link

atedja commented Feb 26, 2015

@yvasiyarov Considering that your pull-request has been going on for about 4 months now, and considering that rcrowley/go-metrics has not had any activity in the past 4 months, can you make your go-metrics fork public? I can't find your yvasiyarov/go-metrics.

edit: actually nvm. it couldn't find the repo before, but now it does.

@yvasiyarov
Copy link
Owner

@atedja you can find this and few more fixes in this fork - https://bitbucket.org/lazadaweb/go-metrics

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants