OpenSpades crashes if core_locale is invalid

[feikname]

Version: 0.1.0 (development)

Steps to reproduce:

• Edit SPConfig.cfg to have an invalid core_locale (one that can't be found or does not exist)
• Launch OpenSpades
• It crashes right after loading the splash screen.

Expected behaviour:

• Silently ignore the error and load the default strings. OR
• Show the error and ask to change core_locale to an valid one.

Files and logs:
SPConfig.cfg, SystemMessages.log and a link to the Crash Dump can be found inside this Gist.

[mschlumpp]

I can't reproduce it on my system. What kind of "invalid" 'core_locale' did you use? Also a backtrace could be useful.

[feikname]

@theunknownxy

I used an inexistent one. I will try to reproduce it with latest build and provide a backtrace tomorrow.

EDIT: Done.

[VelocityRa]

Here's a callstack (you'll still probably want to repro it yourself if you want to fix it):

I changed the core_locale to pc_cp, restarted the client, crash occured (read access violation).

[VelocityRa]

The bug is here, I think it's trying to print a string that's not null-terminated:

[yvt]

This was the actual cause of the issue:

 					SPLog("Catalog file for the locale '%s' was not found. (domain='%s')",
-					      domainName.c_str());
+					      currentLocaleRegion.c_str(), domainName.c_str());