Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] Support proxy protocol #100

Closed
thetechnick opened this issue Jul 25, 2017 · 1 comment
Closed

[feature request] Support proxy protocol #100

thetechnick opened this issue Jul 25, 2017 · 1 comment
Assignees
Labels
Milestone

Comments

@thetechnick
Copy link
Contributor

thetechnick commented Jul 25, 2017

I am experimenting with replacing haproxy with gobetween as TCP/UDP lb in front of a kubernetes cluster.
For most of my deployments the preservation of the client IP is mandatory for logging/auditing and rate limiting on application level.

To preserve the client IP I currently use proxy protocol terminated at the kubernetes ingress controller (nginx).
https://www.haproxy.org/download/1.8/doc/proxy-protocol.txt

Proxy Protocol is implemented by:

  • HAProxy
  • AWS ELB
  • Nginx

So I want to ask if it is possible to include support for proxy protocol in gobetween.
After doing a quick scan through the code base I think it would be very simple to add the header information to the connection handling about here:
https://github.com/thetechnick/gobetween/blob/master/src/server/tcp/server.go#L345

@yyyar yyyar added the feature label Jul 28, 2017
@yyyar yyyar added this to the 0.5.0 milestone Jul 28, 2017
@yyyar yyyar self-assigned this Sep 28, 2017
@yyyar
Copy link
Owner

yyyar commented Sep 28, 2017

Done as #101

@yyyar yyyar closed this as completed Sep 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants