Inline code block outline is too dark on light background

[nyanpasu64]

What is the problem?

If "Syntax: Decorations" are enabled, and you pick a light theme, then inline code blocks have too dark of an outline around them.

How can I reproduce it?

• Set "markdown.extension.syntax.decorations": true.
• Set "workbench.colorTheme": "Default Light+" (switch to light editor color theme).

Screenshot:

[yzhang-gh]

Thanks for the feedback. The color was picked based on a dark theme I was using, although I switched to a light one recently.

We now have the API to know the theme kind (microsoft/vscode#32813 (comment)) but picking a proper color is still challenging as there are many different themes.

[nyanpasu64]

Does vscode's extension or theme engine let you pick the color by blending 10-20% of the foreground color into the background color (linearly interpolating between them) in linear or sRGB-gamma color space?

[yzhang-gh]

That's a good idea, although we cannot access the theme color yet.

[Lemmingh]

I don't think we really need the actual color value. Color reference sounds enough in this case.

What about editor.selectionBackground?

[yzhang-gh]

I roughly know that VS Code now provides ThemeColor APIs? As for which color to use, we can play around with it and then decide.

[Lemmingh]

VS Code now provides ThemeColor APIs?

Emmm ... No. The ThemeColor class has NOT been changed. It still only acts as a reference to workbench color, and the VS Code team seems unwilling to expose the actual value inside.

---

play around

I only tested selection colors and word highlight colors with the built-in Light, Dark, and Monokai themes, and the following looked good to me:

• editor.selectionBackground
• editor.wordHighlightStrongBackground

Thinking selectionBackground is usually brighter, I suggested it.

I'm on VS Code 1.51.0, on Windows, with a calibrated 100% sRGB display.

[yzhang-gh]

👍

[Lemmingh]

Let's try it?
https://github.com/yzhang-gh/vscode-markdown/actions?query=workflow%3ACI+branch%3Aadd%2Fdecoration-color

[yzhang-gh]

Nice work!

Just to add a few screenshots

GitHub Light

GitHub Dark

Actually, I don't have a strong preference on the colors. So looks good to me.

[Lemmingh]

If nothing is wrong, I will push to master at 2020-11-15T12:00Z.