Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Zcash signed message" for Zclassic #135

Open
ch4ot1c opened this issue Jan 15, 2018 · 3 comments
Open

"Zcash signed message" for Zclassic #135

ch4ot1c opened this issue Jan 15, 2018 · 3 comments
Labels
consensus enhancement zCLASH collision with Zcash defaults, binary name, ports, etc.. zclassicify improve prompts and documentation by changing Zcash=>Zclassic, ZEC=>ZCL, etc..
Milestone
v2.0.1

Comments

@ch4ot1c
Copy link
Collaborator

ch4ot1c commented Jan 15, 2018

https://github.com/z-classic/zclassic/blob/master/src/main.cpp#L98

If I were to make a PR changing this to "Zclassic Signed Message:\n", would it be accepted? What are the implications of this as we move toward BTCP?

Here is the prior discussion:
zcash#1371
@ch4ot1c
Copy link
Collaborator Author

ch4ot1c commented Jan 15, 2018

#25

@ch4ot1c ch4ot1c mentioned this issue Jan 16, 2018
Merged
@ch4ot1c ch4ot1c added the zclassicify improve prompts and documentation by changing Zcash=>Zclassic, ZEC=>ZCL, etc.. label Feb 9, 2018
ch4ot1c referenced this issue in z-classic/zclassicjs Jul 5, 2018
@11000000110000110100001101011010
zclassicjs based on zencashjs
5a399fd
@ch4ot1c
Copy link
Collaborator Author

ch4ot1c commented Sep 3, 2018

This is stuck as-is, given consensus.

@nimbosa
Copy link
Member

nimbosa commented Sep 7, 2018

This can be implemented in the Overwinter/Sapling Upgrade.

@nimbosa nimbosa added this to the v2.0.1 milestone Sep 19, 2018
@nimbosa nimbosa added the zCLASH collision with Zcash defaults, binary name, ports, etc.. label Sep 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
consensus enhancement zCLASH collision with Zcash defaults, binary name, ports, etc.. zclassicify improve prompts and documentation by changing Zcash=>Zclassic, ZEC=>ZCL, etc..
Projects
None yet
Milestone
v2.0.1
Development

No branches or pull requests
2 participants
@ch4ot1c @nimbosa